Re: [Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 8/8/19 9:41 AM, Alex Bennée wrote:
>> index 21c0615e020..f146924623c 100644
>> --- a/target/mips/cpu.h
>> +++ b/target/mips/cpu.h
>> @@ -5,7 +5,8 @@
>>
>>  #include "cpu-qom.h"
>>  #include "exec/cpu-defs.h"
>> -#include "fpu/softfloat.h"
>> +#include "fpu/softfloat-types.h"
>> +#include "fpu/softfloat-helpers.h"
>
> Do you really need softfloat-helpers.h here?
> It appears as if this is only needed by target/mips/internal.h

I've moved the helper to internal.h which somehow gets auto-magically
included for cpu_loop.c for linux-user.

>
>
> r~


--
Alex Bennée