Re: [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types

[Richard Henderson]

On 8/8/19 9:41 AM, Alex Bennée wrote:
> This simple pasting helper can be used by those who don't need the
> entire softfloat api. Move it to the smaller types header.
> 
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  include/fpu/softfloat-types.h | 2 ++
>  include/fpu/softfloat.h       | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/fpu/softfloat-types.h b/include/fpu/softfloat-types.h
> index 2aae6a89b19..7e88152dfc4 100644
> --- a/include/fpu/softfloat-types.h
> +++ b/include/fpu/softfloat-types.h
> @@ -80,6 +80,8 @@ this code that are retained.
>  #ifndef SOFTFLOAT_TYPES_H
>  #define SOFTFLOAT_TYPES_H
>  
> +#define LIT64( a ) a##LL

Better would be to replace all uses with {,U}INT64_C from <stdint.h>.

But if you prefer this smaller patch for now,
Acked-by: Richard Henderson <address@hidden>


r~