[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: remove unused variables
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: remove unused variables |
Date: |
Tue, 6 Aug 2019 09:04:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 06/08/19 08:40, Gerd Hoffmann wrote:
> Well, the commit message pretty much says it. We have sdl.mo in both
> ui/ and audio/ (final module names are audio-sdl.so and ui-sdl.so).
>
> This certainly was needed back when I added it. Possibly it can be
> removed now, I don't follow build system changes that closely. But
> it should be build-tested both ui/sdl and audio/sdl enabled.
Will do. However, audio-obj-y has not existed since commit b0b68fc671
("build: move audio/ objects to nested Makefile.objs", 2012-06-07), and
ui-obj-y since 8867aef02e ("build: move ui/ objects to nested
Makefile.objs", 2012-06-07). audio-obj-m and ui-obj-m has never existed
as far as I can tell.
My understanding is that the two are audio/sdl.mo and ui/sdl.mo, and
even though the sdl.mo-* variables seem to conflict, they are rewritten
to audio/sdl.mo-{cflags,libs,objs} and ui/sdl.mo-{cflags,libs,objs} when
unnest-vars-recursive calls fix-paths.
Paolo