[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: remove unused variables
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: remove unused variables |
Date: |
Tue, 06 Aug 2019 07:48:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> Paolo Bonzini <address@hidden> writes:
>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> Makefile | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 73fbba0..7b0e2f4 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -429,10 +429,6 @@ dummy := $(call unnest-vars,, \
>> io-obj-y \
>> common-obj-y \
>> common-obj-m \
>> - ui-obj-y \
>> - ui-obj-m \
>> - audio-obj-y \
>> - audio-obj-m \
>> trace-obj-y)
>>
>> include $(SRC_PATH)/tests/Makefile.include
>
> Reviewed-by: Markus Armbruster <address@hidden>
Hmm... the two go back to
commit 08a05b379ac56430cbb748882ff1b48dc9fe8729
Author: Gerd Hoffmann <address@hidden>
Date: Tue Mar 6 08:40:49 2018 +0100
build: enable audio modules
Add audio/ to common-obj-m variable.
Also run both audio and ui variables through unnest-vars.
This avoids sdl.mo (exists in both audio/ and ui/) name clashes.
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
Gerd, anything funny going on here, or is Paolo's patch okay?