Re: [Qemu-devel] [PATCH 21/47] hw/char/Kconfig: Add Kconfig file

[Andreas Färber]

Am 26.08.2013 12:43, schrieb Paolo Bonzini:
> Il 26/08/2013 00:58, Ákos Kovács ha scritto:
>> Signed-off-by: Ákos Kovács <address@hidden>
>> ---
>>  hw/char/Kconfig |   24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>  create mode 100644 hw/char/Kconfig
>>
>> diff --git a/hw/char/Kconfig b/hw/char/Kconfig
>> new file mode 100644
>> index 0000000..7ad0bd3
>> --- /dev/null
>> +++ b/hw/char/Kconfig
>> @@ -0,0 +1,24 @@
>> +config IPACK 
>> +    bool
>> +    depends on PCI
> 
> PCI devices are generally configurable, so you need to add prompts to them.

IndustryPack is really misplaced in hw/char/ and I believe I posted
patches to remedy that and let one actually find it in our source tree.
There were no objections against hw/ipack/, alternatively it could go
into hw/gpio/. (Currently my patch series is waiting to be respun due to
changed QOM realize requirements from Anthony.)

That having being said, IndustryPack does not depend on PCI, only the
TPCI2000(?) PCI-IndustryPack bridge does.

Andreas

> 
>> +config ESCC
>> +    bool
>> +
>> +config PARALLEL
>> +    bool
>> +    #select ISA
> 
> Also "depends on" here.  You probably also want to make all these ISA
> devices configurable, so add a prompt.
> 
> Paolo
> 
>> +config SERIAL
>> +    bool
>> +    #select ISA
>> +
>> +config SERIAL_PCI
>> +    bool
>> +    depends on PCI
>> +
>> +config SCLPCONSOLE
>> +    bool
>> +
>> +config PL011
>> +    bool
>>
> 
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg