Re: [Qemu-devel] [PATCH 19/47] hw/audio/Kconfig: Add audio Kconfig

[Paolo Bonzini]

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <address@hidden>
> ---
>  hw/audio/Kconfig |   41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 hw/audio/Kconfig
> 
> diff --git a/hw/audio/Kconfig b/hw/audio/Kconfig
> new file mode 100644
> index 0000000..bb6c31d
> --- /dev/null
> +++ b/hw/audio/Kconfig
> @@ -0,0 +1,41 @@
> +menu "Audio devices"
> +    config SB16
> +        bool
> +        #select ISA

All these should have "depends on ISA".


> +    config ES1370
> +        bool "ES1370"
> +        depends on PCI
> +
> +    config AC97
> +        bool "AC97 sound card"
> +        default y
> +        depends on PCI
> +
> +    config ADLIB
> +        bool
> +        #select ISA
> +
> +    config CS4231A
> +        bool
> +
> +    config HDA
> +        bool
> +        #select ISA
> +
> +    config PCSPK
> +        bool
> +        select I8254

Perhaps "depends on I8254"?

> +    config WM8750
> +        bool
> +
> +    config PL041
> +        bool
> +
> +    config CS4231
> +        bool
> +
> +    config MARVELL_88W8618
> +        bool
> +endmenu
>