[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 8/8] libvduse: Add support for reconnecting
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v5 8/8] libvduse: Add support for reconnecting |
Date: |
Wed, 18 May 2022 15:03:40 +0100 |
On Wed, May 04, 2022 at 03:40:51PM +0800, Xie Yongji wrote:
> @@ -291,6 +294,15 @@ static int vduse_blk_exp_create(BlockExport *exp,
> BlockExportOptions *opts,
> return -ENOMEM;
> }
>
> + vblk_exp->recon_file = g_strdup_printf("%s/vduse-blk-%s",
> + g_get_tmp_dir(), exp->id);
g_get_tmp_dir() returns the $TMPDIR environment variable. This means
exp->id must be unique across the host. Please document this.
Thanks,
Stefan
signature.asc
Description: PGP signature
- [PATCH v5 1/8] block: Support passing NULL ops to blk_set_dev_ops(), (continued)
- [PATCH v5 1/8] block: Support passing NULL ops to blk_set_dev_ops(), Xie Yongji, 2022/05/04
- [PATCH v5 4/8] linux-headers: Add vduse.h, Xie Yongji, 2022/05/04
- [PATCH v5 7/8] vduse-blk: Add vduse-blk resize support, Xie Yongji, 2022/05/04
- [PATCH v5 2/8] block-backend: Introduce blk_get_guest_block_size(), Xie Yongji, 2022/05/04
- [PATCH v5 8/8] libvduse: Add support for reconnecting, Xie Yongji, 2022/05/04
- Re: [PATCH v5 8/8] libvduse: Add support for reconnecting,
Stefan Hajnoczi <=
[PATCH v5 3/8] block/export: Abstract out the logic of virtio-blk I/O process, Xie Yongji, 2022/05/04
[PATCH v5 6/8] vduse-blk: Implement vduse-blk export, Xie Yongji, 2022/05/04
[PATCH v5 5/8] libvduse: Add VDUSE (vDPA Device in Userspace) library, Xie Yongji, 2022/05/04