qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/18] block: Change blk_{pread,pwrite}() param order


From: Eric Blake
Subject: Re: [PATCH 03/18] block: Change blk_{pread,pwrite}() param order
Date: Wed, 18 May 2022 09:05:39 -0500
User-agent: NeoMutt/20220429-71-6f7d3e

On Tue, May 17, 2022 at 12:37:31PM +0100, Alberto Faria wrote:
> Swap 'buf' and 'bytes' around for consistency with
> blk_co_{pread,pwrite}(), and in preparation to implement these functions
> using generated_co_wrapper.
> 
> Callers were updated using this Coccinelle script:
> 
>     @@ expression blk, offset, buf, bytes, flags; @@
>     - blk_pread(blk, offset, buf, bytes, flags)
>     + blk_pread(blk, offset, bytes, buf, flags)
> 
>     @@ expression blk, offset, buf, bytes, flags; @@
>     - blk_pwrite(blk, offset, buf, bytes, flags)
>     + blk_pwrite(blk, offset, bytes, buf, flags)
> 
> It had no effect on hw/block/nand.c, presumably due to the #if, so that
> file was updated manually.
> 
> Overly-long lines were then fixed by hand.
> 
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> ---

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]