[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] aspeed/smc: Let the SSI core layer define the bus name
From: |
Alistair Francis |
Subject: |
Re: [PATCH 5/6] aspeed/smc: Let the SSI core layer define the bus name |
Date: |
Tue, 8 Mar 2022 16:41:56 +1000 |
On Mon, Mar 7, 2022 at 5:34 PM Cédric Le Goater <clg@kaod.org> wrote:
>
> If no id is provided, qdev automatically assigns a unique ename with
> the following pattern "<type>.<index>".
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/ssi/aspeed_smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
> index f194182beacf..113f31899a6b 100644
> --- a/hw/ssi/aspeed_smc.c
> +++ b/hw/ssi/aspeed_smc.c
> @@ -1130,7 +1130,7 @@ static void aspeed_smc_realize(DeviceState *dev, Error
> **errp)
> /* DMA irq. Keep it first for the initialization in the SoC */
> sysbus_init_irq(sbd, &s->irq);
>
> - s->spi = ssi_create_bus(dev, "spi");
> + s->spi = ssi_create_bus(dev, NULL);
>
> /* Setup cs_lines for peripherals */
> s->cs_lines = g_new0(qemu_irq, asc->max_cs);
> --
> 2.34.1
>
>
- [PATCH 0/6] aspeed/smc: 'num_cs' cleanup, Cédric Le Goater, 2022/03/07
- [PATCH 3/6] aspeed/smc: Remove 'num_cs' field, Cédric Le Goater, 2022/03/07
- [PATCH 6/6] aspeed/smc: Fix error log, Cédric Le Goater, 2022/03/07
- [PATCH 5/6] aspeed/smc: Let the SSI core layer define the bus name, Cédric Le Goater, 2022/03/07
- [PATCH 4/6] aspeed/smc: Rename 'max_peripherals' to 'max_cs', Cédric Le Goater, 2022/03/07
- [PATCH 1/6] aspeed/smc: Use max number of CE instead of 'num_cs', Cédric Le Goater, 2022/03/07
- [PATCH 2/6] aspeed: Rework aspeed_board_init_flashes() interface, Cédric Le Goater, 2022/03/07