qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/6] aspeed/smc: Rename 'max_peripherals' to 'max_cs'


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 4/6] aspeed/smc: Rename 'max_peripherals' to 'max_cs'
Date: Mon, 7 Mar 2022 11:21:21 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1

On 7/3/22 08:18, Cédric Le Goater wrote:
The naming makes more sense in a SPI controller model.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
  include/hw/ssi/aspeed_smc.h |  2 +-
  hw/ssi/aspeed_smc.c         | 42 ++++++++++++++++++-------------------
  2 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/include/hw/ssi/aspeed_smc.h b/include/hw/ssi/aspeed_smc.h
index 4a9354e13c7f..6501a04b8f3e 100644
--- a/include/hw/ssi/aspeed_smc.h
+++ b/include/hw/ssi/aspeed_smc.h
@@ -95,7 +95,7 @@ struct AspeedSMCClass {
      uint8_t r_timings;
      uint8_t nregs_timings;
      uint8_t conf_enable_w0;
-    uint8_t max_peripherals;
+    uint8_t max_cs;

Can we use 'cs_num_max' or 'cs_count_max' instead?

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]