[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-ev
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [PATCH] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb |
|
Date: |
Mon, 9 Aug 2021 10:16:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/9/21 10:01 AM, Joel Stanley wrote:
> On Mon, 9 Aug 2021 at 07:45, Cédric Le Goater <clg@kaod.org> wrote:
>>
>> On 8/8/21 10:04 PM, Guenter Roeck wrote:
>>> Commit 7582591ae7 ("aspeed: Support AST2600A1 silicon revision") switched
>>> the silicon revision for AST2600 to revision A1. On revision A1, the first
>>> Ethernet interface is operational. Enable it.
>>
>> Indeed.
>>
>> I see that commit ba56f464f0c ("ARM: dts: aspeed: ast2600evb: Add MAC0")
>> reintroduced it a while ago. But my A0 doesn't support it. I am missing
>> something.
>>
>> Joel, why this patch didn't reach the OpenBMC kernel ?
>
> Because your a0 doesn't support it, so it would break that. That's the
> only reason.
OK then.
> For this patch,
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
It's queued to aspeed-6.2.
Thanks
C.