Re: [PATCH 01/13] target/arm: Add _aa32_ to isar_feature functions testing 32-bit ID registers

[Richard Henderson]

On 2/11/20 9:37 AM, Peter Maydell wrote:
> Enforce a convention that an isar_feature function that tests a
> 32-bit ID register always has _aa32_ in its name, and one that
> tests a 64-bit ID register always has _aa64_ in its name.
> We already follow this except for three cases: thumb_div,
> arm_div and jazelle, which all need _aa32_ adding.
> 
> (As noted in the comment, isar_feature_aa32_fp16_arith()
> is an exception in that it currently tests ID_AA64PFR0_EL1,
> but will switch to MVFR1 once we've properly implemented
> FP16 for AArch32.)
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target/arm/cpu.h       | 13 ++++++++++---
>  linux-user/elfload.c   |  4 ++--
>  target/arm/cpu.c       |  6 ++++--
>  target/arm/helper.c    |  2 +-
>  target/arm/translate.c |  6 +++---
>  5 files changed, 20 insertions(+), 11 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~