[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Added struct functionality on pk-val
|
From: |
Konstantinos Chasialis |
|
Subject: |
Re: [PATCH] Added struct functionality on pk-val |
|
Date: |
Fri, 29 May 2020 19:52:09 +0300 |
|
User-agent: |
SquirrelMail/1.4.23 [email.uoa.gr] |
> Hm, why? The JSON representation of pk vals should reflect whatever is
> in the pk vals...
I believe that before discussing anything about these functions we need to
agree on the JSON Schema to be used.
I think its a very important aspect before discussing anything about
implementations.
Do you agree on the JSON Schema I posted? You think there is something to
be changed?
Also, please consider the follow-up reply on the JSON Schema thread where
I propose a change on the "Array" object.
>Add an empty line here.
>
> Please do not include an empty line here.
Done.
diff --git a/ChangeLog b/ChangeLog
index d2fbb99b..a36ca78f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,5 @@
2020-05-28 Kostas Chasialis <sdi1600195@di.uoa.gr>
+
* libpoke/libpoke.h (pk_make_struct): Prototype.
(pk_struct_nfields): Likewise.
(pk_struct_nmethods): Likewise.
@@ -12,7 +13,6 @@
(pk_struct_set_method_name): Likewise.
(pk_struct_method_value): Likewise.
(pk_struct_set_method_value): Likewise.
-
* libpoke/pk-val.c (pk_make_struct): Define.
(pk_struct_nfields): Likewise.
(pk_struct_nmethods): Likewise.