[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Added struct functionality on pk-val
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH] Added struct functionality on pk-val |
|
Date: |
Fri, 29 May 2020 18:10:50 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Kostas.
I've made the changes in ChangeLog and libpoke.h.
About the struct methods, I believe we need their interface in order to
build pk_mi_val_to_json. That is, because when we build a struct json
object we need to have access to its methods in order to correctly build
the json_object.
Hm, why? The JSON representation of pk vals should reflect whatever is
in the pk vals...
I've added all functions on ChangeLog, I hope you dont find it unnecessary.
diff --git a/ChangeLog b/ChangeLog
index 7a865d01..d2fbb99b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,32 @@
+2020-05-28 Kostas Chasialis <sdi1600195@di.uoa.gr>
Add an empty line here.
+ * libpoke/libpoke.h (pk_make_struct): Prototype.
+ (pk_struct_nfields): Likewise.
+ (pk_struct_nmethods): Likewise.
+ (pk_struct_field_boffset): Likewise.
+ (pk_struct_set_field_boffset): Likewise.
+ (pk_struct_field_name): Likewise.
+ (pk_struct_set_field_name): Likewise.
+ (pk_struct_field_value): Likewise.
+ (pk_struct_set_field_value): Likewise.
+ (pk_struct_method_name): Likewise.
+ (pk_struct_set_method_name): Likewise.
+ (pk_struct_method_value): Likewise.
+ (pk_struct_set_method_value): Likewise.
+
Please do not include an empty line here.
+ * libpoke/pk-val.c (pk_make_struct): Define.
+ (pk_struct_nfields): Likewise.
+ (pk_struct_nmethods): Likewise.
+ (pk_struct_field_boffset): Likewise.
+ (pk_struct_set_field_boffset): Likewise.
+ (pk_struct_field_name): Likewise.
+ (pk_struct_set_field_name): Likewise.
+ (pk_struct_field_value): Likewise.
+ (pk_struct_set_field_value): Likewise.
+ (pk_struct_method_name): Likewise.
+ (pk_struct_set_method_name): Likewise.
+ (pk_struct_method_value): Likewise.
+ (pk_struct_set_method_value): Likewise.