Re: [PATCH] Added struct functionality on pk-val

[Jose E. Marchesi]

Hi Kostas.

We need a proper ChangeLog entry.
    
    * libpoke/pk-val.c: Fixed the struct interface
    * libpoke/libpoke.h: Added the associative headers

s/associative/corresponding.
The entries should also be more detailed, indicating what new functions
are defined.  See previous ChangeLog entries for examples.
    
    diff --git a/libpoke/libpoke.h b/libpoke/libpoke.h
    index 5289a310..8df50625 100644
    --- a/libpoke/libpoke.h
    +++ b/libpoke/libpoke.h
    @@ -487,6 +487,111 @@ pk_val pk_offset_magnitude (pk_val val);
    
     pk_val pk_offset_unit (pk_val val);
    
    +/* Structs. */
    +
    +/* Build and return a poke struct.
    +   NFIELDS is an ulong<64> PVM value specifying the number of fields

In the libpoke API there is no distinction between ints an longs, so
please use uint<64> instead.  Also, talk about values, not PVM values
(the PVM is not visible here.)

    +   in the struct.  This can be ulong<64>0 for an empty struct.

Ditto.

    +
    +   NMETHODS is an ulong<64> PVM vlaue specifying the number of methods

Ditto.

    +   in the struct.

Let's not add the struct methods to the interface for the time being.
There is nothing useful the user can do with them.

    +   TYPE is a type PVM value specifying the type of the array.

no PVM.

    +
    +   The fields and methods in the created struct are initialized to
    +   PVM_NULL.*/

PK_NULL.