Re: JSON Representation

[Konstantinos Chasialis]

> Great! I'll watch and learn too.
>
> Welcome Kostas!
>
> Cheers
> Ege
>

I thank you all for this warm welcome! I am really glad I get the
opportunity to work with you!

>
> [People: Konstantinos is a student participating in this year's GSOC,
>  and I will be mentoring him in the project/task of adding a fucking
>  AWESOME machine-interface to poke.  Just wait and see :)]
>
> Hi Konstantinos.
>
> Great start :)
> Please find some comments below.

Hello, thank you for your comments. Tell me what you think about the changes.

Author: kostasch <address@hidden>

    Changes to json representation

 libpoke/pvm-val.json | 49 +++++++++++++++++++++++++++++++++++++------------
 1 file changed, 37 insertions(+), 12 deletions(-)


diff --git a/libpoke/pvm-val.json b/libpoke/pvm-val.json
index 98d37d5d..b7ea3633 100644
--- a/libpoke/pvm-val.json
+++ b/libpoke/pvm-val.json
@@ -1,24 +1,44 @@
 {
     "$schema": "http://json-schema.org/draft-06/schema#";,
     "$id": "",
-    "title" : "PVMValuesRepresentation",
-    "description" : "JSON Representation for PVM values",
+    "title" : "Poke values",
+    "description" : "JSON Representation for Poke values",
     "definitions" : {
-        "Integral": {
+            "UnsignedInteger" : {
+                    "type" : "object",
+                    "properties" : {
+                            "value" : {
+                                    "type" : "integer",
+                                    "minimum" : 0
+                            },
+                            "size" : {
+                                    "type" : "UnsignedInteger",
+                                    "maximum" : 4294967295
+                            }
+                    },
+                 "required": [
+                "size",
+                "value"
+            ],
+            "title": "UnsignedInteger"
+            },
+        "Integer": {
             "type": "object",
             "properties": {
                 "value": {
                     "type": "integer"
                 },
-                "size": {
-                    "type": "integer"
+                "size" : {
+                        "type" : "UnsignedInteger",
+                        "maximum" : 4294967295
                 }
+
             },
             "required": [
                 "size",
                 "value"
             ],
-            "title": "Integral"
+            "title": "Integer"
         },
         "Null": {
             "type": "object",
@@ -35,16 +55,21 @@
         "Offset": {
             "type": "object",
             "properties": {
-                "identifier": {
-                    "type": "string"
+                "magnitude": {
+                    "type": "integer",
+                    "oneOf" : [
+                            {"type" : "UnsignedInteger"},
+                            {"type" : "Integer"}
+                    ]
                 },
-                "size": {
-                    "type": "integer"
+                "base": {
+                    "type": "UnsignedInteger",
+                    "maximum" : 9223372036854775807
                 }
             },
             "required": [
-                "identifier",
-                "size"
+                "magnitude",
+                "base"
             ],
             "title": "Offset"
         },