Re: [Phpgroupware-users] Login loop

[Dave Hall]

Hi Bob (and Bob (and others) ),

On Mon, 2005-05-30 at 08:52 -0400, Bob Bosiljevac wrote:
> I am not sure if this is related to the problem below or not but I am
> having a login loop issue as well. In my case, I am reasonably certain it
> is related to the '&' in the redirect URLs being rendered as '&' in
> the actual request.

This is the problem.  I tested the fix before leaving for a weeks
holiday and it seemed to be working fine.  On getting back I looked over
this thread and found the problem.

& is not valid in html4 (the target markup for 16) and it was causing me
a lot of problems trying to trackdown a layout bug with a new template
and causing screens of tidy errors.

& is valid for html4/xhtml1+ but not for header redirects.  I have
almost finished fixing all of the know cases of the problem.

The main issue is that phpgw::redirect_link() must be called not any
other possible way of calling it.

A full fix will be in cvs in the next day or so.

> 
> This is what shows up in my log:
> 
> GET 
> /home.php?cd=yes&sessionid=916118973e0bd96a77517a4c9567a5f8&kp3=cfd9d773440fad211acf946ae83e481a&domain=default&PHPSESSID=916118973e0bd96a77517a4c9567a5f8&click_history=5ef7909662c081e69a160e0aad2f4cd1
>  HTTP/1.1" 302 5
> 
> This can't be right.
> 
> Can anybody give me a clue as to how I can fix this?
> 
> Bob.
> 
> 
> 
> On Tue, 24 May 2005, Bob Crandell wrote:
> 
> > From: Bob Crandell <address@hidden>
> > To: phpGroupware Users <address@hidden>
> > Date: Tue, 24 May 2005 18:30:05 +0000
> > Subject: [Phpgroupware-users] Login loop
> > Reply-To: address@hidden
> >
> > Hi,
> >
> > I have a client with phpgroupware version 0.9.16.005 updated this morning.
> > Apache is v1.3.33.  Mysql is 3.23.56
> >
> > When a user, any user tries to login, they are returned to the login screen.
> >
> > When an incorrect user name or password is tried the phpGW returns the 
> > proper
> > error.  There are no messags in var/log/apache/error_log related to this.  
> > The
> > access_log shows web activity thusly:
> > 66.78.90.70 - - [24/May/2005:11:26:29 -0700] "POST /phpgroupware/login.php
> > HTTP/1.1" 302 5
> > 66.78.90.70 - - [24/May/2005:11:26:29 -0700] "GET
> > /phpgroupware/home.php?cd=yes&sessionid=52936c9f2f6fe35beec5760c92f60123&kp3=52d03faec47a22f3c125054d5f9dcf98&domain=default&PHPSESSID=52936c9f2f6fe35beec5760c92f60123&click_history=a7d7580e93f2f944e33d106a271fc10a
> > HTTP/1.1" 302 5
> > 66.78.90.70 - - [24/May/2005:11:26:29 -0700] "GET /phpgroupware/login.php
> > HTTP/1.1" 200 2291
> >
> > I seem to remember someone having this issue not too long ago but I couldn't
> > find the thread.  Could some kind soul help me track this down?
> >
> > Please?
> >
> > Thanks
> >
> > --
> > Bob Crandell, CLS, CNS
> > Assured Computing, Inc.
> > When you need to be sure.
> > http://www.assuredcomp.com/
> > 921 Country Club Road, Suite 100
> > Eugene, OR 97402
> > Voice - 541-868-0331
> > FAX - 541-463-1627
> >
> > This message is intended solely for the use of the individual and entity to
> > whom it is addressed, and may contain information that is privileged,
> > confidential, and exempt from disclosure under applicable state and federal
> > laws. If you are not the addressee, or are not authorized to receive for the
> > intended addressee, you are hereby notified that you may not use, copy,
> > distribute, or disclose to anyone this message or the information contained
> > herein. If you have received this message in error, immediately advise the
> > sender by reply email and destroy this message.
> >
> >
> >
> >
> > _______________________________________________
> > Phpgroupware-users mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/phpgroupware-users
> >
> 
> 
> _______________________________________________
> Phpgroupware-users mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/phpgroupware-users
-- 
Dave Hall (aka skwashd)
API Coordinator
phpGroupWare
-------------------------------------------------------------------------
Do you think if Bill Gates got laid in high school, do you think there'd 
be a Microsoft?  Of course not.
Underwear Goes Inside The Pants by Lazy Boy