phpgroupware-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Phpgroupware-users] Important Changes to 16preRC API


From: Dan Kuykendall
Subject: Re: [Phpgroupware-users] Important Changes to 16preRC API
Date: Wed, 09 Jul 2003 08:21:06 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

I am working hard and fast on my new security class. It can accomplish much of the same thing that the validator does. I have not looked at the validator code, but by looking at the examples you have given of what the apps are using it for, I will be able to replace those functions with mine by tomorrow. The app will still need to be updated from using the validator class to the security class, but other than that it should be an easy transition.

Also, my security class probably offers more features, because its designed to cover ALL inputs, including those coming in from soap and xmlrpc

Dan

Chris Weiss wrote:
that's why I said "if it isn't in conflict with your license", and it is in 
conflict
with (L)GPL.  Not everyone on this list has apps in CVS and they might also be 
using
that class.

Dave Hall (address@hidden) wrote:

This is not completely correct.  This file can not be used in app hosted
in savannah.gnu.org's cvs tree.  Be that the API or an app.  Also all
our apps are GPL'd, so this file can not be linked to a GPL app.

Also be aware that the replacement class with be added to HEAD cvs.

Chris Weiss <address@hidden> wrote:


It should be noted that this class could be copied to the apps if
it isn't in
conflict with your license.  While it is possible to include "non-
free" code in
phpgw apps, this is not possible in the API.

However, this validator code has a confusing license as the
license it names doesn't
exsist and it puts non-free exclutions on what it seems is a GNU
license which is
not legal on GNU's licenses.  This is a class to beware of if you
are at all
conserned about *GPL'ing your code.



Dave Hall (address@hidden) wrote:

Hi all,

We have had to remove a class from the API, and during a code

audit it

was found to be non-free and so can not live in our cvs tree on
savannah, and does not belong in the project.

The class has been stubbed in the 16 and HEAD branches.

Please be careful when running cvs updates if you use the affected
applications (bookmarks or email).  Any calls to a method of this

class>will terminate the application.  A list of effected code is
listed at

the end of this email.

As part of the stubbing of the class the following output is

generated:>class.validator.inc.php used to contain code that was
not Free Software

(see definition(link to fsf)), therefore it has been removed.

If you are a application maintainer, please update your app. If

you are

a user, please file a bug report on our project page at
savannah.gnu.org(link). Please copy and paste the following

information>into the bug report:

Summary: CurrentApp calls class.validator.inc.php
Information:
The call was found when calling: $_GET[] args

This application will now halt!

Return to Home Screen(link)



Cheers

Dave

Use of the class - based on a grep

Bookmarks Code
class.bo.inc.php
42: $this->validate = createobject('phpgwapi.validator');
164: if ($this->validate($values))
186: if ($this->validate($values) && $this-
check_perms($id,PHPGW_ACL_EDIT))>244: if (! $this->validate-
is_url($values['url']))>248: URL!<br><small>' .  $this->validate-
ERROR . '</small>';

class.ui.inc.php
998: $validate = createobject('phpgwapi.validator');
1000: $to = $validate->strip_space($GLOBALS['HTTP_POST_VARS']['to']);
1021: if (!$validate->is_email($val))
1025: '<br><small>'.$validate->ERROR.'</small>';

Email Code
class.bocompose.inc.php
193: $this->my_validator = CreateObject("phpgwapi.validator");
195: $bodystring = $this->my_validator->strip_html($bodystring);
431: $this->my_validator = CreateObject("phpgwapi.validator");
433: $bodystring = $this->my_validator->strip_html($bodystring);

class.spell.inc.php
158: $this->my_validator = CreateObject("phpgwapi.validator");
485: //elseif ($this->my_validator->is_email($str) == True)
491: elseif ($this->my_validator->is_url($str) == True)
496: elseif ($this->my_validator->is_hostname($str) == True)




_______________________________________________
Phpgroupware-users mailing list
address@hidden
http://mail.gnu.org/mailman/listinfo/phpgroupware-users





_______________________________________________
Phpgroupware-users mailing list
address@hidden
http://mail.gnu.org/mailman/listinfo/phpgroupware-users





reply via email to

[Prev in Thread] Current Thread [Next in Thread]