Re: [Phpgroupware-users] Important Changes to 16preRC API

[Chris Weiss]

It should be noted that this class could be copied to the apps if it isn't in
conflict with your license.  While it is possible to include "non-free" code in
phpgw apps, this is not possible in the API.

However, this validator code has a confusing license as the license it names 
doesn't
exsist and it puts non-free exclutions on what it seems is a GNU license which 
is
not legal on GNU's licenses.  This is a class to beware of if you are at all
conserned about *GPL'ing your code.



Dave Hall (address@hidden) wrote:
>
>Hi all,
>
>We have had to remove a class from the API, and during a code audit it
>was found to be non-free and so can not live in our cvs tree on
>savannah, and does not belong in the project.
>
>The class has been stubbed in the 16 and HEAD branches.
>
>Please be careful when running cvs updates if you use the affected
>applications (bookmarks or email).  Any calls to a method of this class
>will terminate the application.  A list of effected code is listed at
>the end of this email.
>
>As part of the stubbing of the class the following output is generated:
>class.validator.inc.php used to contain code that was not Free Software
>(see definition(link to fsf)), therefore it has been removed.
>
>If you are a application maintainer, please update your app. If you are
>a user, please file a bug report on our project page at
>savannah.gnu.org(link). Please copy and paste the following information
>into the bug report:
>Summary: CurrentApp calls class.validator.inc.php
>Information:
>The call was found when calling: $_GET[] args
>
>This application will now halt!
>
>Return to Home Screen(link)
>
>
>
>Cheers
>
>Dave
>
>Use of the class - based on a grep
>
>Bookmarks Code
>class.bo.inc.php
>42: $this->validate = createobject('phpgwapi.validator');
>164: if ($this->validate($values))
>186: if ($this->validate($values) && $this->check_perms($id,PHPGW_ACL_EDIT))
>244: if (! $this->validate->is_url($values['url']))
>248: URL!<br><small>' .  $this->validate->ERROR . '</small>';
>
>class.ui.inc.php
>998: $validate = createobject('phpgwapi.validator');
>1000: $to = $validate->strip_space($GLOBALS['HTTP_POST_VARS']['to']);
>1021: if (!$validate->is_email($val))
>1025: '<br><small>'.$validate->ERROR.'</small>';
>
>Email Code
>class.bocompose.inc.php
>193: $this->my_validator = CreateObject("phpgwapi.validator");
>195: $bodystring = $this->my_validator->strip_html($bodystring);
>431: $this->my_validator = CreateObject("phpgwapi.validator");
>433: $bodystring = $this->my_validator->strip_html($bodystring);
>
>class.spell.inc.php
>158: $this->my_validator = CreateObject("phpgwapi.validator");
>485: //elseif ($this->my_validator->is_email($str) == True)
>491: elseif ($this->my_validator->is_url($str) == True)
>496: elseif ($this->my_validator->is_hostname($str) == True)
>