octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #59850] Add missing function "uniquetol"


From: Markus Mützel
Subject: [Octave-bug-tracker] [bug #59850] Add missing function "uniquetol"
Date: Sun, 21 Mar 2021 09:47:16 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36 Edg/89.0.774.57

Update of bug #59850 (project octave):

                 Summary: uniquetol missing, so I implemented it => Add
missing function "uniquetol"

    _______________________________________________________

Follow-up Comment #26:

I applied your patch locally and made only some whitespace changes. Please,
see the attached updated patch.

I can confirm that the test case without "byrows" set to true is much faster
now.
Also, the `x = 1:.045:3` seems to be working now.

However, NaN values don't seem to be treated as different values any longer:

>> uniquetol ([-Inf, 1, NaN, Inf, NaN, Inf])
ans =

  -Inf     1   Inf   NaN


In Matlab R2021a:

>> uniquetol ([-Inf, 1, NaN, Inf, NaN, Inf])

ans =

  -Inf     1   Inf   NaN   NaN


Could you please check if it is possible to return all NaNs also with the new
fast path?


(file #51098)
    _______________________________________________________

Additional Item Attachment:

File name: bug59850_uniquetol_performance_v2.patch Size:5 KB
   
<https://file.savannah.gnu.org/file/bug59850_uniquetol_performance_v2.patch?file_id=51098>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59850>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]