monotone-debian
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-debian] Review, please?


From: Richard Levitte
Subject: Re: [Monotone-debian] Review, please?
Date: Sat, 16 Apr 2011 01:31:15 +0200 (CEST)

In message <address@hidden> on Wed, 13 Apr 2011 00:08:00 +0100, Francis Russell 
<address@hidden> said:

francis> Hi Richard,
francis> 
francis> I pushed another couple of commits if you could have a look. One last
francis> issue is the files purging monotone leaves behind that are owned by no
francis> user. In particular, it also looks like purging monotone-server can 
also
francis> leave unowned files in /etc.
francis> 
francis> Either we could check to see if each of the problem paths exists.
francis> Alternatively, we could explicitly run find to locate any files in 
those
francis> paths owned by the monotone user/group.
francis> 
francis> Thoughts?

I'm not sure about the find solution.  However, it seems to me that if
/var/run/monotone still exists for some reason, the monotone user and
group shouldn't be removed, just like if /var/lib/monotone still
exists.  I've made a change for that and pushed it moments ago, see
revision 1fae06279d7da2329c2596e09422e8b2517b5cfa.

Your changes seem to the point :-)

Cheers,
Richard

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"Life is a tremendous celebration - and I'm invited!"
-- from a friend's blog, translated from Swedish



reply via email to

[Prev in Thread] Current Thread [Next in Thread]