|
From: | Martin Pala |
Subject: | Re: Some feature notes for monit, volume III |
Date: | Wed, 14 Jul 2004 22:54:12 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040707 Debian/1.7-5 |
Jan-Henrik Haukeland wrote:
I think it would be much better to unify functions that read RAM structures to one skeleton and call the tag printing routines in accordance to the format requested. This way all formats would provide the same set of information and there is only one code to maintain.Excellent suggestion. The design would be somewhat similar to [XML->XSLT->to whatever] which is a good model.
I'm working on this 'by accident' ;) I'm implementing historical/status data for m/moit. To simplify and unify monit service status, i though that it will be good to colect data once to the memory structure and then present it as many times as needed without need to gather it again.
It simplifies the code a lot and provides:- common service error bitmap (maintained by event engine). It allows to display state by one simple function
- one-time data gathering, which places the actual service parameters data into the memory structure. It provides consistent view between main and http thread, simplify the code a lot and allows the addition of simple code which just presents the collected data. One of these presentation channels will be binded to m/monit data collector.
I think it will be ready probably next week or later (i can't work on it more hard because of baby ;)
Martin
[Prev in Thread] | Current Thread | [Next in Thread] |