Re: Some feature notes for monit, volume III

[Christian Hopp]

On Wed, 14 Jul 2004, Jan-Henrik Haukeland wrote:

> > ### Refactoring of the HTTP output, unify
> >
> > There is a separate set of output routines for HTML and TEXT/XML in
> > http/cervlet.c. I believe the simple XML output was originally added
> > for communication with the m/monit to pass the true/false information
> > about each service. The goal was not to provide an exhaustive
> > information.
>
> You are right about that assumption.
>
> > I think it would be much better to unify functions that read RAM
> > structures to one skeleton and call the tag printing routines in
> > accordance to the format requested. This way all formats would provide
> > the same set of information and there is only one code to maintain.
>
> Excellent suggestion. The design would be somewhat similar to
> [XML->XSLT->to whatever] which is a good model.
>
> > If the core developers will tell me, that they like it
> > and that such change would make it to their monit, I'm willing to code
> > it. :-)
>
> I like it and speaking for myself I will strongly support this plan.
> The current code for output is messy and refactoring this according to
> your design proposal will certainly improve the code. In other words
> here is my +1 vote for your suggestion. Can the other commiters please
> cast their votes on this proposal also. I.e. if we will accept a patch
> as outlined.

And you can have my +1 to it too...

Christian

-- 
Christian Hopp                                email: address@hidden
Institut für Elektrische Informationstechnik             fon: +49-5323-72-2113
TU Clausthal, Leibnizstr. 28, 38678 Clausthal-Zellerf.   fax: +49-5323-72-3197
                             pgpkey: https://www.iei.tu-clausthal.de/pgp-keys/