Re: [lwip-users] std includes

[Kieran Mansley]

On Thu, 2011-07-14 at 10:51 +0200, Simon Goldschmidt wrote:
> > It sounds like if we move the standard includes to before the lwip
> > includes in the files that use them it would solve your problem, is
> > that correct?
> 
> Sounds like it. However, it might just be the other way round for
> another OS/library setup, so I don't think we should change the
> include order because of this particular problem. We could only solve
> this in a general way by moving all includes to non-lwIP files to a
> central place where the port could change them.

The conflict between the use of the DEBUG value in Timmy's system could
work the other way in another setup, and so I agree in that sense that
changing the include order in lwIP would be futile.

However the more general point that lwIP headers might depend on system
headers, but system headers will not depend on lwIP headers, and so the
system headers should come first is a good one. I think it would improve
lwIP to do it that way.

That this will solve Timmy's issue, and/or might cause a similar issue
in some other system, is in some sense a secondary issue (apologies to
Timmy!).

Kieran