RE: [lwip-users] Strange "always true" conditional in tcp_in.c

[Bill Yang]

Hi,

I wonder if any one can help me to attach "lwippools.h" head file to this 
email, since I cannot allocate one in lwIP web page. I use win32 version.

Thanks, 
Bill Yang

Software Engineer

direct:    +1 801.433.6354
email:   address@hidden


Parvus

RUGGED SOLUTIONS for REAL WORLD APPLICATIONS

USA – 3222 S. Washington St. | Salt Lake City, Utah 84115 | Tel. +1 
801.483.1533 | Fax +1 801.483.1523 |
www.parvus.com    

A Member of EUROTECH GROUP

-----Original Message-----
From: address@hidden [mailto:address@hidden On Behalf Of Simon Goldschmidt
Sent: Monday, March 01, 2010 2:06 AM
To: Mailing list for lwIP users
Subject: Re: [lwip-users] Strange "always true" conditional in tcp_in.c


Lou Cypher wrote:
> The case above isn't always true, in fact it yields false when
> pcb->dupacks == 0xFF.
> May be that was the intended behavior? Then could have been shorter (and
> more
> intuitive) checking for
>   if( pcb->dupacks != 0xFF )

The original check intends to be still valid if the type of 'dupacks' is 
changed in the future, therefore, I think it is better than explicitly checking 
for a constant (0xFF). This kind of check is used in multiple places throughout 
the stack and should have a comment stating that this is an overflow check.

I didn't check yet if the bug report here is valid, but at least under 
VS2005/2008 and cygwin-gcc, there is no such warning...

Simon
-- 
Sicherer, schneller und einfacher. Die aktuellen Internet-Browser -
jetzt kostenlos herunterladen! http://portal.gmx.net/de/go/atbrowser


_______________________________________________
lwip-users mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/lwip-users