Re: [lwip-users] Strange "always true" conditional in tcp_in.c

[Lou Cypher]

> On line 883 of core/tcp_in.c is the somewhat strange construct...
> 883 :                  if (pcb->dupacks + 1 > pcb->dupacks)

That would be always true, indeed

> Perhaps what was meant was...
>   if( (u8_t)(pcb->dupacks+1) > ....
> 
> Even that is dubious since 1 is an int

I don't catch the sense of the last note.
The case above isn't always true, in fact it yields false when pcb->dupacks == 
0xFF.
May be that was the intended behavior? Then could have been shorter (and more
intuitive) checking for
  if( pcb->dupacks != 0xFF )
...

~ Lou