[lwip-devel] [bug #11400] ARP multi-packet-queue modifies TCP unsent/unacked segment packet pbuf chain into packet queue

[Kieran Mansley]

Follow-up Comment #16, bug #11400 (project lwip):

Right, so we need to work out why the current implementation isn't working
(because it should) rather than just copying the whole lot.

Sounds to me like pbuf_take() has some bugs in it.  The way I'd like it to
work is:
 - rather than allocate a new pbuf structure for any REF types, just change
the existing pbuf structure to be a RAM type and copy the data.  This should
avoid the problem where something else has a reference to the pbuf
structure.
 - this should also sort out the pbuf_ref() problem, as the ref count should
still reflect all those people who have a handle on this pbuf.  I'd like to
see the pbuf_ref() call move into pbuf_take() as it is essentially part of
that operation.

Also, pbuf_queue() is no longer used and could be purged.

Any volunteers?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?11400>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/