Re: [lmi] GUI unit test failures after the recent changes

[Greg Chicares]

On 5/14/22 15:07, Vadim Zeitlin wrote:
[...]
>  I've fixed this in https://github.com/let-me-illustrate/lmi/pull/208 which

Similar code in gpt_view::OnCreate() and mec_view::OnCreate()
uses the same try...catch. If we're going to remove it from
IllustrationView::OnCreate(), we should remove it from all.
I tried doing that just now, but where PR 208 has:

    if(!!ViewEx::DoOnCreate(doc, flags))
>>>>>> ^^ double '!'
        {
        return false;
        }

in the other two files I came up with:

    if(!ViewEx::DoOnCreate(doc, flags))
>>>>>> ^ single '!'
        {
        return false;
        }

which differs only in that it uses a single '!' rather than two.
Isn't a single '!' correct? Thus, I think the logic should be:

  call DoOnCreate (expecting it to succeed)
  if it failed, return false
  if it succeeded, then proceed to call Run()

I'll push mine as a new branch:
  
https://git.savannah.nongnu.org/cgit/lmi.git/log/?h=odd/remove-all-view-report-exception
Please let me know if I should merge that into master.