Re: [lmi] [PATCH] Use submodules for, and newer versions of, libxml2 and libxslt

[Vadim Zeitlin]

On Fri, 2 Oct 2020 12:06:16 +0000 Greg Chicares <gchicares@sbcglobal.net> wrote:

GC> On 2020-10-01 16:21, Vadim Zeitlin wrote:
GC> > On Thu, 1 Oct 2020 15:33:31 +0000 Greg Chicares <gchicares@sbcglobal.net> 
wrote:
GC> > 
GC> > GC> Should we upgrade to the latest libxml2 now, just because it's the
GC> > GC> perfect time for that?
GC> [...]
GC> >  So I wanted to write that I'll do it soon, but then I started wondering 
if
GC> > it could be useful for you to try to do it just to ensure that you can do
GC> > it if necessary? Please let me know if you'd be interested in such an
GC> > exercise (I hope asking you this right now doesn't constitute abuse of
GC> > weakness...).
GC> 
GC> The latest official release is 41a34e1f:
GC>   https://gitlab.gnome.org/GNOME/libxml2/-/tags/v2.9.10

 Speaking of this, I don't know if we should use v2.9.10 or master. I see
quite a few post-2.9.10 commits that seem to be worth including, just have
a look at

        $ git log --oneline --reverse v2.9.10..master | grep " Fix"

for a few of them, purporting to fix crashes, memory leaks, catastrophic
slowdowns (due to quadratic complexity) etc. I think they're going to
release v2.9.11 soon, because 2.9.10 was almost a year ago and, unlike some
other projects, they do seem to release regularly, but we can't wait for it
if we want to do this now. And then I think using master is better. BTW,
notice that we don't use an official release of libxslt neither, because it
doesn't include a fix required for building it with MinGW 10.1, so it
wouldn't be surprising or inconsistent to use the current master of libxml2
too.


GC> I did spend some time trying to figure this out. Editing '.gitmodules',

 Oh, just let me get this out of the way: you're never supposed to edit
this file directly. You can, of course, but this is never the official way
of doing things.

GC> >  In this particular case, I think we should just upgrade libxml2, which
GC> > will fix this issue as a side effect.
GC> > 
GC> >  Just please let me know if we should do it or if you will,
GC> 
GC> ...yes, please do update libxml2.

 I will do it soon but, just for the reference, the way it works is just
that you update the lmi branch in the submodule (in whichever way you see
fit, i.e. by fast-forwarding it to v2.9.10 tag, merging with master,
whatever), then pushing submodule to its origin (which, as I'm belatedly
realizing, you can't do without a GitHub account...) and then committing
the submodule in the parent repository and pushing it instead. I.e.
updating a submodule is mostly like updating any other file in Git.

 But, anyhow, as I said, I'll do it, especially because you can't do it
anyhow, sorry for forgetting about it! Just please let me know if you
object to using libxml2 master and would rather stick to v2.9.10.

 Thanks in advance,
VZ

pgpoeRz_VbQWY.pgp
Description: PGP signature