Re: [lmi] [PATCH] Use submodules for, and newer versions of, libxml2 and libxslt

[Greg Chicares]

On 2020-09-29 23:57, Vadim Zeitlin wrote:
> 
>  Here is, finally, the promised patch:
> 
>       https://github.com/vadz/lmi/pull/153
> 
>  Please note that you will need to run
> 
>       $ git submodule update --init
> 
> after merging it to actually initialize the submodules unless you rerun
> install_msw.sh, which was updated to do it.

Pushed, with a couple little self-explanatory follow-up commits.

It passes all tests [skipping the few that I always skip, myself]:

/opt/lmi/bin[0]$/opt/lmi/src/lmi/gui_test.sh
NOTE: starting the test suite
SUCCESS: 21 tests successfully completed.
NOTE: 4 tests were skipped

/opt/lmi/src/lmi[0]$time ./nychthemeral_test.sh                                 
             
LMI_TRIPLET = "x86_64-w64-mingw32"
  Production system built--ready to start GUI test in another session.
  Do not forget to run the 'gui_test.sh' script.
LMI_TRIPLET = "i686-w64-mingw32"
  Production system built--ready to start GUI test in another session.
  Do not forget to run the 'gui_test.sh' script.
./nychthemeral_test.sh  8895.28s user 478.80s system 1225% cpu 12:44.96 total

Should we upgrade to the latest libxml2 now, just because it's the
perfect time for that? Are we already at the latest lib{xslt,exslt}?

One oddity: after rerunning 'install_msw.sh', I notice this:

/opt/lmi/src/lmi[0]$git --no-pager diff
diff --git a/third_party/libxml2 b/third_party/libxml2
--- a/third_party/libxml2
+++ b/third_party/libxml2
@@ -1 +1 @@
-Subproject commit bdec2183f34b37ee89ae1d330c6ad2bb4d76605f
+Subproject commit bdec2183f34b37ee89ae1d330c6ad2bb4d76605f-dirty

This submodule is not flagged as "dirty":

  /opt/lmi/src/lmi/third_party/libxslt[0]$git status               
  HEAD detached at 6a46106d
  nothing to commit, working tree clean

but this submodule is:

  /opt/lmi/src/lmi/third_party/libxml2[0]$git status
  HEAD detached at bdec2183
  Untracked files:
    (use "git add <file>..." to include in what will be committed)
          compile

  nothing added to commit but untracked files present (use "git add" to track)

How should we handle it?

 - Add this 'compile' file to third_party/libxml2/.gitignore , as I
suppose upstream should have done? But then we diverge from them,
making any future update complicated.

 - Remove that file in 'install_libxml2_libxslt.sh'? That seems
more robust, though perhaps silly.

Or is some other way better?