Re: [lmi] Toolbar subtleties

[Vadim Zeitlin]

On Wed, 19 Aug 2015 16:32:44 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2015-08-16 17:07, Greg Chicares wrote:
GC> > First of all, don't read this before September, especially not if you're
GC> > on vacation.
GC> 
GC> I have a few questions about this patch:
GC> 
GC> --- /lmi/mirror/lmi/toolbar.xrc     2015-04-09 16:34:32.620122000 +0000
GC> +++ a00/copy/original/toolbar.xrc   2015-08-16 16:13:58.937500000 +0000
GC> @@ -115,10 +115,21 @@
GC>          <bitmap stock_id="write-spreadsheet"/>
GC>          <longhelp>Run and print all cells to a spreadsheet file</longhelp>
GC>      </object>
GC> -    <object class="tool" name="print_group_roster">
GC> -        <tooltip>Print roster to spreadsheet</tooltip>
GC> +    <object class="tool" name="print_group"> ??? QUESTION 1 ???
GC> +        <tooltip>Print roster</tooltip> ??? QUESTION 2 ???
GC>          <bitmap stock_id="roster"/>
GC> -        <longhelp>Run and print group roster to a spreadsheet 
file</longhelp>
GC> +        <dropdown>
GC> +            <object class="wxMenu">
GC> +                <object class="wxMenuItem" name="print_group_roster">
GC> +                    <label>Print r_oster to spreadsheet</label> ??? 
QUESTION 3 ???
GC> +                    <help>Run and print group roster to a spreadsheet 
file</help> ??? QUESTION 4 ???
GC> +                </object>
GC> +                <object class="wxMenuItem" name="print_group_premiums">
GC> +                    <label>Print group premium quotes</label>
GC> +                    <help>Create a PDF file with group premium 
quotes</help>
GC> +                </object>
GC> +            </object>
GC> +        </dropdown>
GC>      </object>
GC>      <object class="separator"/>
GC>      <object class="tool" name="paste_census">
GC> 
GC> Questions, line by line:
GC> 
GC> +    <object class="tool" name="print_group"> ??? QUESTION 1 ???
GC> 
GC> Does this object require a "name"?

 It didn't require it when you asked this question, but it does/will
require it now if the patch from the "Group premium quotes: UI" thread is
applied (http://lists.nongnu.org/archive/html/lmi/2015-08/msg00057.html),
as the name is needed to disable the tool when it's inapplicable.

GC> +        <tooltip>Print roster</tooltip> ??? QUESTION 2 ???
GC> 
GC> Would an ellipsis be stylistically appropriate here? I.e.:
GC>   <tooltip>Print roster...</tooltip>

 I don't think so, ellipsis should be used at the end of the menu items
only, not in the toolbar tools tooltips. Microsoft is, perhaps, not always
the best example to follow, but I've just tried adding the "Print..."
command (which appears like this, with an ellipsis, in the menu, as it
opens the standard print dialog) to the toolbar in MSVS and it doesn't show
the ellipsis in the toolbar tool tooltip, as expected.

GC> +                    <label>Print r_oster to spreadsheet</label> ??? 
QUESTION 3 ???
GC> 
GC> I can't find a way to see the 'o' underlined with msw; on that platform,
GC> I suppose it just can't have any effect. But I'm going to retain it,
GC> because I can pull down the similar-looking "Get new messages" button
GC> in icedove and strike the 'g' key, underlined in the pulldown menu,
GC> to get all messages...so it seems reasonable to hope for a similar
GC> result on lmi-wx-gtk.

 Yes, indeed, it works there as can be seen in e.g. the toolbar sample
(which is simpler to build than lmi itself...).

GC> +                    <help>Run and print group roster to a spreadsheet 
file</help> ??? QUESTION 4 ???
GC> 
GC> Why <help> here, whereas <longhelp> is used elsewhere? Let me guess:
GC> because this is inside a <dropdown><object class="wxMenu"> section,
GC> so it's really a menu, and menus use <help>. Right?

 Exactly.
VZ