[lmi] Toolbar subtleties [Was: Group premium quotes]

[Greg Chicares]

On 2015-08-16 17:07, Greg Chicares wrote:
> First of all, don't read this before September, especially not if you're
> on vacation.

I have a few questions about this patch:

--- /lmi/mirror/lmi/toolbar.xrc 2015-04-09 16:34:32.620122000 +0000
+++ a00/copy/original/toolbar.xrc       2015-08-16 16:13:58.937500000 +0000
@@ -115,10 +115,21 @@
         <bitmap stock_id="write-spreadsheet"/>
         <longhelp>Run and print all cells to a spreadsheet file</longhelp>
     </object>
-    <object class="tool" name="print_group_roster">
-        <tooltip>Print roster to spreadsheet</tooltip>
+    <object class="tool" name="print_group"> ??? QUESTION 1 ???
+        <tooltip>Print roster</tooltip> ??? QUESTION 2 ???
         <bitmap stock_id="roster"/>
-        <longhelp>Run and print group roster to a spreadsheet file</longhelp>
+        <dropdown>
+            <object class="wxMenu">
+                <object class="wxMenuItem" name="print_group_roster">
+                    <label>Print r_oster to spreadsheet</label> ??? QUESTION 3 
???
+                    <help>Run and print group roster to a spreadsheet 
file</help> ??? QUESTION 4 ???
+                </object>
+                <object class="wxMenuItem" name="print_group_premiums">
+                    <label>Print group premium quotes</label>
+                    <help>Create a PDF file with group premium quotes</help>
+                </object>
+            </object>
+        </dropdown>
     </object>
     <object class="separator"/>
     <object class="tool" name="paste_census">

Questions, line by line:

+    <object class="tool" name="print_group"> ??? QUESTION 1 ???

Does this object require a "name"?

+        <tooltip>Print roster</tooltip> ??? QUESTION 2 ???

Would an ellipsis be stylistically appropriate here? I.e.:
  <tooltip>Print roster...</tooltip>
                       ^^^
My suspicion is that the ellipsis is reserved for menu items that bring up
a dialog. It would look wrong on the corresponding menu (where the solid
triangular arrow pointing rightward clearly indicates that there's a submenu),
and therefore it would be wrong here.

+                    <label>Print r_oster to spreadsheet</label> ??? QUESTION 3 
???

I can't find a way to see the 'o' underlined with msw; on that platform,
I suppose it just can't have any effect. But I'm going to retain it,
because I can pull down the similar-looking "Get new messages" button
in icedove and strike the 'g' key, underlined in the pulldown menu,
to get all messages...so it seems reasonable to hope for a similar
result on lmi-wx-gtk.

+                    <help>Run and print group roster to a spreadsheet 
file</help> ??? QUESTION 4 ???

Why <help> here, whereas <longhelp> is used elsewhere? Let me guess:
because this is inside a <dropdown><object class="wxMenu"> section,
so it's really a menu, and menus use <help>. Right?