Re: [lmi] wx_test_expiry_dates.cpp

[Greg Chicares]

On 12/15/2014 03:46 PM, Vadim Zeitlin wrote:
[...]
>  I was reluctant to do it like this because it doesn't check for the exact
> format ("%04d%02d%02d") and so would "work" on strings like "141215" which
> could have been expected to mean "20141215" but, of course, don't.

I never know what Americans mean when they write a date like 04/05/06,
and I'm an American. A date like "141215" is simply an error IMO.

> OTOH I'm
> probably overcomplicating things as usual and lmi users and especially
> testers are probably familiar with ISO 8601 format considering that it's
> already used in other places, so I've finally overcome this reluctance to
> produce the attached patch.

Committed 20150123T0213Z, revision 6090.

>  I've tested it and it results in the expected, albeit not always very
> precise, errors if an invalid date is specified.

Good, because to clear my backlog of your patches I'm following this
philosophy:
  'Regression testing'? What's that? If it compiles, it is good;
  if it boots up, it is perfect.
I just hope that guy has somebody checking his work.