Re: [lmi] wx_test_config_settings.cpp

[Murphy, Kimberly]

Greg Chicares wrote:

> On 2014-12-14 21:01, Vadim Zeitlin wrote:
> > On Fri, 12 Dec 2014 13:19:01 +0000 Greg Chicares
> <address@hidden> wrote:
> >
> > GC> // ERASE THIS BLOCK COMMENT WHEN IMPLEMENTATION COMPLETE. The block
> > GC> // comment below changes the original specification, and does not
> > GC> // yet describe the present code. Desired changes:
> > GC> //  - Run this test only when the '--distribution' option is given.
> >
> >  Here is the trivial patch doing just this.
> 
> Committed 20141215T1353Z, revision 6075.
> 
> >  AFAICS there is nothing more to do for this one.
> 
> I agree.

I thought so too but, one distribution's test failed:

configurable_settings: started
configurable_settings: ERROR (Assertion '"skin_coli_boli.xrc" == skin || 
"skin_group_carveout.xrc" == skin || "skin_group_carveout2.xrc" == skin || 
"skin_reg_d.xrc" == skin' failed (unknown skin skin_single_premium.xrc). [file 
/opt/lmi/src/lmi/wx_test_config_settings.cpp, line 101] )

After adding the missing particulars, the test passed:

/opt/lmi/src/lmi[0]$diff -u wx_test_config_settings.cpp_REAL \
wx_test_config_settings.cpp
--- wx_test_config_settings.cpp_REAL    2015-01-20 08:20:28.000000000 -0500
+++ wx_test_config_settings.cpp 2015-01-22 08:50:20.984063800 -0500
@@ -61,6 +61,9 @@
           <skin_filename>skin_reg_d.xrc</skin_filename>
           
<default_input_filename>c:/fop-0.20.5/private_placement_default.ill</default_input_filename>

+          <skin_filename>skin_single_premium.xrc</skin_filename>
+          
<default_input_filename>c:/fop-0.20.5/default.ill</default_input_filename>
+
     The only change is that the xsl_fo_command is checked to contain the 
volume,
     i.e. is c:/fop-0.20.5/fop, and not just the path.
  */
@@ -97,6 +100,7 @@
         || "skin_group_carveout.xrc" == skin
         || "skin_group_carveout2.xrc" == skin
         || "skin_reg_d.xrc" == skin
+        || "skin_single_premium.xrc" == skin
         ,"unknown skin " << skin
         );
     if ("skin_coli_boli.xrc" == skin)
@@ -115,5 +119,9 @@
         {
         LMI_ASSERT_EQUAL(default_input, 
"c:/fop-0.20.5/private_placement_default.ill");
         }
+    if ("skin_single_premium.xrc" == skin)
+        {
+        LMI_ASSERT_EQUAL(default_input, "c:/fop-0.20.5/default.ill");
+        }
 }




This e-mail transmission may contain information that is proprietary, 
privileged and/or confidential and is intended exclusively for the person(s) to 
whom it is addressed. Any use, copying, retention or disclosure by any person 
other than the intended recipient or the intended recipient's designees is 
strictly prohibited. If you are not the intended recipient or their designee, 
please notify the sender immediately by return e-mail and delete all copies.