Re: [lmi] Input-sequence editor testing

[Greg Chicares]

On 2011-07-10 13:37Z, Vaclav Slavik wrote:
> 
> diff --git a/input_sequence_entry.cpp b/input_sequence_entry.cpp
> index 0a0fb9a..d472b37 100644
> --- a/input_sequence_entry.cpp
> +++ b/input_sequence_entry.cpp
[...]
> @@ -1238,6 +1251,8 @@ void InputSequenceEntry::UponOpenEditor(wxCommandEvent&)
>  
>      editor.sequence(sequence);
>  
> +    editor.CentreOnParent();
> +
>      if(wxID_OK == editor.ShowModal())
>          {
>          text_->SetValue(editor.sequence_string());

There's a slight collision between this patch and the one here:
  http://lists.nongnu.org/archive/html/lmi/2011-07/msg00005.html
After applying the older one, this newer one succeeds with --fuzz=3,
so I applied it locally and checked its effects. All the other hunks
[elided above] seem to have applied in an obviously correct way, but
I just want to confirm this one. The older patch did this:

-    if(wxID_OK == editor.ShowModal())
-        {
-        text_->SetValue(editor.sequence_string());
-        }
+    editor.associate_text_ctrl(text_);
+    editor.ShowModal();
 }

and the newer one, applied afterwards, does this in the last hunk:

     editor.sequence(sequence);

     editor.associate_text_ctrl(text_);
+    editor.CentreOnParent();

     editor.ShowModal();
 }

It's almost obvious to me that this is certainly correct, and I've
confirmed that it resolves the centering issue, so please just let
me know if I've applied this hunk incorrectly.