[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] a less trivial patch: don't use deprecated MakeDefaultName() +
From: |
Greg Chicares |
Subject: |
Re: [lmi] a less trivial patch: don't use deprecated MakeDefaultName() + refactoring |
Date: |
Mon, 26 May 2008 13:22:21 +0000 |
User-agent: |
Thunderbird 2.0.0.14 (Windows/20080421) |
On 2008-05-25 23:50Z, Vadim Zeitlin wrote:
> On Wed, 21 May 2008 16:58:01 +0000 Greg Chicares <address@hidden> wrote:
>
> GC> > 2. Remove LMI_WX_CHILD_DOCUMENT before passing flags to wxDocument.
> GC> >
> GC> > I think it is wrong to use undefined (at wx level) flags with
> GC> > wxDocument, at the very least this may (and should, although
> currently
> GC> > doesn't) result in an assert about unknown flag.
> GC>
> GC> That's a good point. Can you write a patch that fixes this one
> GC> problem only please?
>
> Hello again,
>
> I've undone the changes which I had proposed in my local copy now and so
> all that remains is this trivial patch:
It seems to create an anomaly. Try the commands here:
https://savannah.nongnu.org/support/?104485
with and without this patch. See also:
http://lists.nongnu.org/archive/html/lmi/2008-03/msg00038.html