Re[2]: [lmi] a less trivial patch: don't use deprecated MakeDefaultName() + refactoring

[Vadim Zeitlin]

On Wed, 21 May 2008 16:58:01 +0000 Greg Chicares <address@hidden> wrote:

GC> > 2. Remove LMI_WX_CHILD_DOCUMENT before passing flags to wxDocument.
GC> > 
GC> >    I think it is wrong to use undefined (at wx level) flags with
GC> >    wxDocument, at the very least this may (and should, although currently
GC> >    doesn't) result in an assert about unknown flag.
GC> 
GC> That's a good point. Can you write a patch that fixes this one
GC> problem only please?

 Hello again,

  I've undone the changes which I had proposed in my local copy now and so
all that remains is this trivial patch:

--- illustration_document.cpp   2008-05-16 13:54:27 +0000
+++ illustration_document.cpp   2008-05-25 23:48:12 +0000
@@ -91,6 +91,9 @@
     if(LMI_WX_CHILD_DOCUMENT & flags)
         {
         is_phony_ = true;
+
+        // Remove the unknown (to wx) flag before passing it to the library.
+        flags &= ~LMI_WX_CHILD_DOCUMENT;
         }

     // TODO ?? Why not offer doc_.read(filename)?

 Thanks,
VZ