lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use GhostScript API instead of forking (issue 548030043 by address@h


From: hanwenn
Subject: Re: Use GhostScript API instead of forking (issue 548030043 by address@hidden)
Date: Sat, 02 May 2020 03:15:40 -0700

https://codereview.appspot.com/548030043/diff/559960055/lily/general-scheme.cc
File lily/general-scheme.cc (right):

https://codereview.appspot.com/548030043/diff/559960055/lily/general-scheme.cc#newcode778
lily/general-scheme.cc:778: free (a);
the code mixes setting up the GS instance (memory management etc) with
handling the file. Does it have to be this way? Can we have a 

  class Ghostscript {
     process(string file, string device);
     close();
  };

  Ghostscript *get_gs(vector<string> args);

instead?

I think it should be possible to construct the API such that we always
have ly:gs , and that it falls back to shelling out to GS if the API is
not available.

https://codereview.appspot.com/548030043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]