|
From: | lemzwerg |
Subject: | Re: Issue 4550: Avoid "using namespace std; " in included files (Take 2) (issue 579240043 by address@hidden) |
Date: | Thu, 23 Jan 2020 03:33:11 -0800 |
I'm quite sure that you have more experience with C++ than me, however, I'm not really happy with this change since it makes the code substantially uglier. Isn't there another solution for the problem? https://codereview.appspot.com/579240043/diff/577360043/flower/include/file-name.hh File flower/include/file-name.hh (right): https://codereview.appspot.com/579240043/diff/577360043/flower/include/file-name.hh#newcode47 flower/include/file-name.hh:47: std::string root_; This is very ugly. What about using the `std` namespace within a group instead? https://codereview.appspot.com/579240043/
[Prev in Thread] | Current Thread | [Next in Thread] |