lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 4550: Avoid "using namespace std; " in included files (Take 2)


From: jonas . hahnfeld
Subject: Re: Issue 4550: Avoid "using namespace std; " in included files (Take 2) (issue 579240043 by address@hidden)
Date: Thu, 23 Jan 2020 04:10:50 -0800

https://codereview.appspot.com/579240043/diff/577360043/flower/include/file-name.hh
File flower/include/file-name.hh (right):

https://codereview.appspot.com/579240043/diff/577360043/flower/include/file-name.hh#newcode47
flower/include/file-name.hh:47: std::string root_;
On 2020/01/23 11:33:11, lemzwerg wrote:
> This is very ugly.  What about using the `std` namespace within a
group instead?

Why is this ugly? std::string is really the name of the class. See this
SO thread on my "using namespace" is considered back practice:
https://stackoverflow.com/q/1452721/10606944

https://codereview.appspot.com/579240043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]