[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch.
From: |
Alexey Abramov |
Subject: |
[bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch. |
Date: |
Sat, 30 May 2020 18:44:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Alexey,
>
> Thanks for the patch series!
>
> Alexey Abramov <levenson@mmer.org> skribis:
>
>> * gnu/packages/java.scm (java-openjfx-build)[source]: Use it.
>> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New
>> file.
>> * gnu/local.mk (dist_patch_DATA): Add it.
>
> [...]
>
>> +++ b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>> @@ -0,0 +1,37 @@
>
> Could you shorten this file name a bit? (‘guix lint’ probably complains.)
Sure. By the way it complains on other derrived packages like java-openjfx-base
which inherits java-openjfx-build.
/home/levenson/factory/guix/gnu/packages/java.scm:2486:12:
java-openjfx-build@8.202: source not archived on Software Heritage
/home/levenson/factory/guix/gnu/packages/java.scm:2533:2:
java-openjfx-base@8.202: file names of patches should start with the package
name
/home/levenson/factory/guix/gnu/packages/java.scm:2537:0:
java-openjfx-base@8.202: line 2537 is way too long (111 characters)
/home/levenson/factory/guix/gnu/packages/java.scm:2552:0:
java-openjfx-base@8.202: line 2552 is way too long (99 characters)
/home/levenson/factory/guix/gnu/packages/java.scm:2533:2:
java-openjfx-base@8.202: source not archived on Software Heritage
>
>> +From d156313340d3edcd78751ea8ed5e66c7668275c3 Mon Sep 17 00:00:00 2001
>> +From: Alexey Abramov <levenson@mmer.org>
>> +Date: Sun, 8 Mar 2020 20:07:22 +0100
>> +Subject: [PATCH] openjfx: Determine the version of Java in JDK_HOME
>
> In general I think you can omit the first three lines and just keep the
> subject.
Ah, great.
>
>> +Icedtea contains guix in its version, so build.gradle failes to run. Openjfx
>> +packaging is not trivial, so you will probably need to try build it with
>> +gradlew.
>
> Otherwise LGTM.
--
Alexey
- [bug#41360] [PATCH 06/12] gnu: java-openjfx-swt: Add new variable., (continued)
- [bug#41360] [PATCH 06/12] gnu: java-openjfx-swt: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 07/12] gnu: java-openjfx-controls: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a complete compilation., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 04/12] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8, Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 08/12] gnu: java-openjfx-build: Prepare a patch to build openjfx-web., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch., Ludovic Courtès, 2020/05/23
- [bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch.,
Alexey Abramov <=
- [bug#41360] [PATCH v2 1/9] gnu: java-openjfx-build: Add helpful patch., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 2/9] gnu: java-openjfx-build: Fix indentation., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 5/9] gnu: java-openjfx-swing: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 4/9] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8, Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 6/9] gnu: java-openjfx-swt: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 7/9] gnu: java-openjfx-controls: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 9/9] gnu: java-openjfx-web: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 8/9] gnu: java-openjfx-build: Prepare a patch to build openjfx-web., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 3/9] gnu: java-openjfx-graphics: Implement a complete compilation., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable., Alexey Abramov, 2020/05/30