[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable.
From: |
Ludovic Courtès |
Subject: |
[bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable. |
Date: |
Sat, 23 May 2020 16:09:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Alexey Abramov <address@hidden> skribis:
> ---
> gnu/packages/java.scm | 165 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 165 insertions(+)
Please add a commit log.
[...]
> + (add-after 'build 'generate-headers
> + (lambda* (#:key inputs #:allow-other-keys)
Could you add a comment explaining what this phase does and why we’re
doing all this? (Same for the other phases.)
> + (let* ((module (string-append (getcwd) "/modules/web"))
> + (classes (string-append module
> "/build/classes/java/main"))
> + (web-generated-headers (string-append module
> "/build/generated-src/headers"))
> + (web-generated-classes '("com.sun.webkit.ContextMenu"
> + "com.sun.webkit.ContextMenuItem"
> + "com.sun.webkit.CursorManager"
Perhaps add a comment explaining how you obtained this list of classes
so that our future selves know how to update it.
Since this is a Web thing, could you check whether it contains pre-built
(“minified”) JavaScript? If it does, that’s a problem because we
generally provide only software built from source.
Could you send an updated patch series?
Thank you for the hard work!
Ludo’.
- [bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch., (continued)
- [bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 02/12] gnu: java-openjfx-build: Fix indentation., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 05/12] gnu: java-openjfx-swing: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 06/12] gnu: java-openjfx-swt: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 07/12] gnu: java-openjfx-controls: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a complete compilation., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable.,
Ludovic Courtès <=
- [bug#41360] [PATCH 04/12] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8, Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 08/12] gnu: java-openjfx-build: Prepare a patch to build openjfx-web., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch., Ludovic Courtès, 2020/05/23
- [bug#41360] [PATCH v2 1/9] gnu: java-openjfx-build: Add helpful patch., Alexey Abramov, 2020/05/30