[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a comple
From: |
Alexey Abramov |
Subject: |
[bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a complete compilation. |
Date: |
Sat, 30 May 2020 18:45:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Ludovic Courtès <ludo@gnu.org> writes:
> Alexey Abramov <levenson@mmer.org> skribis:
>
>> ---
>> gnu/packages/java.scm | 643 +++++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 635 insertions(+), 8 deletions(-)
>
> Please add a commit log.
>
>> + (java-aux-class?
>> + (lambda (class)
>> + (string-match "\\$[0-9]+.class" class)))
>
> Probably “\\.class” instead of “.class”?
Ah, that sneaky dot. Thanks!
>
>> + (add-after 'chdir-to-a-module-directory 'compile-prism-compilers
>> + (lambda _
>
> Maybe add a comment explaining why this phase is necessary.
Well, you know, I managed to eliminate it. Thanks!
>
>> + (let ((prism-compilers-classes
>> "build/classes/jsl-compilers/prism")
>> + (prism-src "src/main/jsl-prism/"))
>> + (mkdir-p prism-compilers-classes)
>> + (apply invoke `("javac"
>> + "-d" ,prism-compilers-classes
>> + ,@javac/h-flags
>> + ,@(find-files prism-src "\\.java"))))
>
> This can be shortened as:
>
> (apply invoke "javac" "-d" prism-compilers-classes
> (append javac/h-flags (find-files prism-src "\\.java")))
>
> These two comments apply to the other phases too.
>
> More generally, why are there so many phases? How do people normally
> build it? Gradle?
>
> Would it make sense to factorize helpers in a new (gnu build
> java-openjfx) module or similar?
You are right, javafx builds with Gradel. I basically replicated gradle
stages, by inspecting ./gradlew build ... --info
The reason I didn't start building any helpers is because OpenJFX 8u and
OpenJFX 9u or later use different instuctions as it states here [1]. I don't
know if these helpers will apply to 9u, also having a (gnu build gradle) would
eliminate the need in helpers as well. In any case I think it won't be a
problem to do that with a second iteration of openjfx build.
--
Alexey
Footnotes:
[1] https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX+8u
- [bug#41360] [PATCH v2 1/9] gnu: java-openjfx-build: Add helpful patch., (continued)
- [bug#41360] [PATCH v2 1/9] gnu: java-openjfx-build: Add helpful patch., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 2/9] gnu: java-openjfx-build: Fix indentation., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 5/9] gnu: java-openjfx-swing: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 4/9] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8, Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 6/9] gnu: java-openjfx-swt: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 7/9] gnu: java-openjfx-controls: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 9/9] gnu: java-openjfx-web: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 8/9] gnu: java-openjfx-build: Prepare a patch to build openjfx-web., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v2 3/9] gnu: java-openjfx-graphics: Implement a complete compilation., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a complete compilation.,
Alexey Abramov <=
- [bug#41360] [PATCH v3 1/9] gnu: java-openjfx-build: Add helpful patch., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v3 2/9] gnu: java-openjfx-build: Fix indentation., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v3 6/9] gnu: java-openjfx-swt: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v3 7/9] gnu: java-openjfx-controls: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v3 4/9] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8, Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v3 9/9] gnu: java-openjfx-web: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v3 8/9] gnu: java-openjfx-build: Prepare a patch to build openjfx-web., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v3 5/9] gnu: java-openjfx-swing: Add new variable., Alexey Abramov, 2020/05/30
- [bug#41360] [PATCH v3 3/9] gnu: java-openjfx-graphics: Implement a complete compilation., Alexey Abramov, 2020/05/30