guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Another misleading commit log (was Re: A "cosmetic changes" commit t


From: Ricardo Wurmus
Subject: Re: Another misleading commit log (was Re: A "cosmetic changes" commit that removes security fixes)
Date: Thu, 22 Apr 2021 23:24:25 +0200
User-agent: mu4e 1.4.15; emacs 27.2


Léo,

On Thu, 2021-04-22 at 13:40 -0400, Mark H Weaver wrote:
This commit was digitally signed and pushed to the 'wip-gnome' branch
by
Raghav, but it's also "Signed-off-by: Léo Le Bouter", so I'm not sure
who bears primary responsibility for this one.

It seems you are more focused and spend more time sending accusations here than collaboratively working to improve GNU Guix. I don't feel
like that's something great to do at all.

Please try to deescalate.

While I disagree with Mark’s earlier style and harsh tone towards Raghav (who has been trying to get more of his older commits that are relevant for a speedy upgrade of Gnome in shape), it seems obvious now that Mark attempts to understand what signing off on the changed commit means in this case – what motivated the expansion of the scope of the commit, what resulted in not declaring all of the significant changes.

I do think it is reasonable to expect an explanation, so that we can collectively address the potential issue (patches removed without upgrade), and prevent it from happening again.

Escalating the situation by insinuating bad faith does not serve any constructive purpose. Obstructing the investigation into what happened will only make it harder to prevent it from happening again. It is in our shared interest to prevent problems like this. Also note that Guix has a pretty good track record when it comes to clear commits, so it is not unusual for long term contributors to be at the very least confused by what has happened here.

--
Ricardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]