Re: Forwarded patch for modular exponentiation support (GMP powm)

[Kevin Ryde]

Eric Hanchrow <address@hidden> writes:
>
> +  if (!coerce_to_big (k, k_tmp))
> +    {
> +      position_of_wrong_type = 2;
> +      goto cleanup;

I'd be inclined to put the necessary clears inline there,

        if (! coerce_and_init (k, k_tmp))
          {
            mpz_clear (n_tmp);
            SCM_WRONG_TYPE_ARG (SCM_ARG2, k);
          }

        if (! coerce_and_init (m, m_tmp))
          {
            mpz_clear (n_tmp);
            mpz_clear (k_tmp);
            SCM_WRONG_TYPE_ARG (SCM_ARG3, m);
          }

Which seems a bit cleaner to me than setting flags.

Or maybe it's just my prejudices against the sort of idiocies with
flags that I remember advocated in Pascal texts. :-)