guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Forwarded patch for modular exponentiation support (GMP powm)


From: Kevin Ryde
Subject: Re: Forwarded patch for modular exponentiation support (GMP powm)
Date: Sat, 14 Feb 2004 10:23:53 +1000
User-agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux)

Eric Hanchrow <address@hidden> writes:
>
> +coerce_to_big (SCM in, mpz_t out)
> +{
>    ...
> +    scm_wrong_type_arg ("modulo-expt", 1, in);

I think there's another memory leak here.  Eg. if k is an invalid type
then n_tmp previously inited is not cleared.

> +  if (SCM_NFALSEP (scm_zero_p (m)))

Probably don't need to call scm_zero_p for that, just
"m==SCM_MAKINUM(0)" I think, since inexacts etc will be rejected by
the coerce.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]