guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Introduction of fractions exposes uniform vector prototype bug


From: Kevin Ryde
Subject: Re: Introduction of fractions exposes uniform vector prototype bug
Date: Tue, 10 Feb 2004 10:05:37 +1000
User-agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux)

The changes will be,

        * unif.c (scm_make_uve, scm_array_p): Allow fraction 1/3 as prototype
        for dvect.
        (scm_array_p): Add missing "break"s in switch, fix llvect test look
        for "l" not "s", fix dvect to reject singp(prot) which is for fvect.
        (scm_array_prototype): Return 1/3 for dvect, rather than 0.33..33.

        * ramap.c (scm_array_fill_x): For fvect and dvect, use scm_num2dbl to
        convert args the same way that array-set! does.

Looks like nobody ever ran array? with the prototype argument, the
missing "break"s made it completely broken.  That fix will be for the
1.6 branch too I think.

(And in 1.6 there needs to be a NIMP before singp in the fvect case.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]