[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/3] Cryptomount detached headers

From: Glenn Washburn
Subject: Re: [PATCH v2 0/3] Cryptomount detached headers
Date: Fri, 27 May 2022 15:20:26 -0500

On Fri, 27 May 2022 16:06:42 +0200
Daniel Kiper <> wrote:

> On Mon, May 16, 2022 at 04:49:45PM -0500, Glenn Washburn wrote:
> > Note: Description here has changed since last time, the last few sentences,
> > which describe a method for allowing backends to bypass the read hook on
> > the source disk.
> >
> > Updates since v1:
> >  * Add marge comment block describing at a high level the read hook 
> > operation
> >    and assumptions.
> >  * Add code to unset read hook on source disk when exiting
> >    grub_cryptodisk_scan_device_real(). A couple return calls were converted
> >    into gotos so that logical flows to one exit point.
> >
> > This patch series is, I believe, a better approach to supporting detached
> > headers for cryptomount and backends. This series will probably not apply
> > cleanly without the changes from the recent series entitled "[PATCH 0/4]
> > Cryptomount keyfile support". But its only because they touch code in the
> > same vicinity, not because there's any real dependency.
> Does not this series require rebase on master after merging "Cryptomount
> keyfile support" patch set? If yes I will review these patches after
> rebase. I hope it will be quick turn around.

The keyfile changes haven't hit master yet, so I can't be sure. But, I
think this should apply cleanly. Randgediff shows no difference between
the patches in the branch for this series and the branch for the latest
keyfile series.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]