[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/3] Cryptomount detached headers

From: Patrick Steinhardt
Subject: Re: [PATCH v2 0/3] Cryptomount detached headers
Date: Sun, 29 May 2022 08:48:41 +0200

On Mon, May 16, 2022 at 04:49:45PM -0500, Glenn Washburn wrote:
> Note: Description here has changed since last time, the last few sentences,
> which describe a method for allowing backends to bypass the read hook on
> the source disk.
> Updates since v1:
>  * Add marge comment block describing at a high level the read hook operation
>    and assumptions.
>  * Add code to unset read hook on source disk when exiting
>    grub_cryptodisk_scan_device_real(). A couple return calls were converted
>    into gotos so that logical flows to one exit point.

I've reviewed this patch series, and except for a single nit the changes
all look good to me. So please feel free to add my

    Reviewed-by: Patrick Steinhardt <>

, regardless of whether you decide to apply my prosed nit in 2/3 or not.


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]