Re: [PATCH 1/4] tests: Show host determined fs UUID when hfs UUID test fails

[Glenn Washburn]

On Fri, 27 May 2022 16:16:48 +0200
Daniel Kiper <dkiper@net-space.pl> wrote:

> On Wed, May 11, 2022 at 10:19:44PM -0500, Glenn Washburn wrote:
> > On failure, the hfs test should show both the host and GRUB determined fs
> > UUID. Prior to this change, both outputs where generated by GRUB, which is
> > less helpful in determining the cause of failure.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  tests/util/grub-fs-tester.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
> > index 3c1d712de..d323665d2 100644
> > --- a/tests/util/grub-fs-tester.in
> > +++ b/tests/util/grub-fs-tester.in
> > @@ -1353,7 +1353,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" 
> > "$MAXLOGSECSIZE" 1); do
> >                     :
> >                 else
> >                     echo UUID FAIL
> > -                   echo "$LSOUT"
> > +                   echo "$FSUUID"
> 
> I am not sure why you drop 'echo "$LSOUT"' here.

I dropped it because I didn't see the utility in keeping it. Perhaps
there is though, and I'm generally in favor of more output on error
than less. I'm not opposed to keeping it in. If you're like to keep
that line, do you want me to spin a new patch series or can you handle
it in the merge?

Glenn